fix(headers): don't generate /TR URLs for no-track statuses#5184
Open
marcoscaceres wants to merge 2 commits intomainfrom
Open
fix(headers): don't generate /TR URLs for no-track statuses#5184marcoscaceres wants to merge 2 commits intomainfrom
marcoscaceres wants to merge 2 commits intomainfrom
Conversation
derivePubSpace() returned /TR for unofficial specs when the group type was 'wg', because the groupType check came before any no-track guard. Now bails early for no-track statuses (unofficial, base, MO) that aren't CG/BG or TAG findings. Closes #4251
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts W3C header URL derivation so “no-track” documents (e.g., unofficial, base, MO) don’t accidentally get /TR publication URLs just because their group type is "wg", addressing the “zombie-life on /TR” behavior from #4251.
Changes:
- Add an early guard in
derivePubSpace()to return an empty pub space for no-track, non-CG/BG, non-TAG-finding specs. - Prevent
/TRpub space selection from the"wg"groupType heuristic when the spec is explicitly no-track.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
derivePubSpace() returned /TR for unofficial specs when the group type was 'wg', because the groupType check came before any no-track guard. Now bails early for no-track statuses (unofficial, base, MO) that aren't CG/BG or TAG findings.
Closes #4251