refactor: remove legacy AMD require shim from expose-modules#5185
Open
marcoscaceres wants to merge 3 commits intomainfrom
Open
refactor: remove legacy AMD require shim from expose-modules#5185marcoscaceres wants to merge 3 commits intomainfrom
marcoscaceres wants to merge 3 commits intomainfrom
Conversation
The fake window.require was created for backward compatibility with the deprecated w3c-common profile. Since w3c-common is frozen and no current plugins depend on this shim, replace it with a no-op. The respecDocWriter require() calls are left intact as they run in the browser context of old specs being processed (separate concern). Closes #5173
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy AMD-style window.require shim from src/core/expose-modules.js (previously used for backward compatibility with the frozen/deprecated w3c-common profile) and keeps the expose() API as a no-op to avoid touching existing call sites. It also updates TypeScript helper typings to stop advertising window.require.
Changes:
- Remove the
window.requireAMD shim logic fromsrc/core/expose-modules.jsand makeexpose()a documented no-op. - Remove
window.requirefrom theWindowinterface insrc/type-helper.d.ts.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/core/expose-modules.js | Drops the legacy AMD shim and turns expose() into a no-op placeholder. |
| src/type-helper.d.ts | Removes the legacy window.require typing from Window. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
With the AMD require shim now a no-op, the 3 remaining expose() calls in pubsubhub, worker, and exporter were dead code. Remove them and delete the expose-modules.js file entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fake window.require was created for backward compatibility with the deprecated w3c-common profile. Since w3c-common is frozen and no current plugins depend on this shim, replace with a no-op. The respecDocWriter require() calls are left intact as they run in the browser context of old specs.
Closes #5173