fix(oauth2-proxy): migrate domains to gluzdov.com#121
Conversation
…m to gluzdov.com Update OAuth2 proxy cookie domains, whitelist domains, redirect URL, CSRF cookie domain, and sign-out URL to use gluzdov.com — matching the production ALB/DNS configuration. EMAIL_DOMAINS intentionally kept as speedandfunction.com (corporate Google Workspace domain). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🤖 CodeRabbit AI Review AvailableTo request a code review from CodeRabbit AI, add CodeRabbit will analyze your code and provide feedback on:
Note: Reviews are only performed when |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughReplaced domain references in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docker-compose.prod.yml (1)
114-114: Consider using environment variable pattern for consistency.The sign-out URL is hardcoded while
OAUTH2_PROXY_REDIRECT_URLon line 92 uses an environment variable with a default fallback. For consistency and flexibility:- - OAUTH2_PROXY_SIGN_OUT_URL=https://temporal.gluzdov.com/oauth2/sign_out + - OAUTH2_PROXY_SIGN_OUT_URL=${OAUTH2_PROXY_SIGN_OUT_URL:-https://temporal.gluzdov.com/oauth2/sign_out}Not blocking—the current change is functionally correct.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docker-compose.prod.yml` at line 114, The OAUTH2_PROXY_SIGN_OUT_URL is hardcoded while OAUTH2_PROXY_REDIRECT_URL uses an env-var with a default; change OAUTH2_PROXY_SIGN_OUT_URL to follow the same pattern by reading an environment variable with a sensible default (e.g., ${OAUTH2_PROXY_SIGN_OUT_URL:-https://temporal.gluzdov.com/oauth2/sign_out}) so both OAUTH2_PROXY_SIGN_OUT_URL and OAUTH2_PROXY_REDIRECT_URL use consistent environment-variable-with-default semantics.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docker-compose.prod.yml`:
- Line 114: The OAUTH2_PROXY_SIGN_OUT_URL is hardcoded while
OAUTH2_PROXY_REDIRECT_URL uses an env-var with a default; change
OAUTH2_PROXY_SIGN_OUT_URL to follow the same pattern by reading an environment
variable with a sensible default (e.g.,
${OAUTH2_PROXY_SIGN_OUT_URL:-https://temporal.gluzdov.com/oauth2/sign_out}) so
both OAUTH2_PROXY_SIGN_OUT_URL and OAUTH2_PROXY_REDIRECT_URL use consistent
environment-variable-with-default semantics.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: 243faa9e-e44d-489c-a3f5-2a6274f71c2e
📒 Files selected for processing (1)
docker-compose.prod.yml
🔍 Vulnerabilities of
|
| digest | sha256:17e54ff5e9a181d1bdbf7334ce9637f9c3934d54a65427ae36a5743f46487f15 |
| vulnerabilities | |
| platform | linux/amd64 |
| size | 218 MB |
| packages | 358 |
📦 Base Image alpine:3
| also known as |
|
| digest | sha256:1c4eef651f65e2f7daee7ee785882ac164b02b78fb74503052a26dc061c90474 |
| vulnerabilities |
Description
Description
Description
Description
Description
Description
Description
Description
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
Description
Description
Description
Description
Description
Description
Description
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
Description
Description
Description
Description | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
Description
Description | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
|
Apply CodeRabbit nitpick: use ${VAR:-default} pattern for SIGN_OUT_URL
to match REDIRECT_URL convention. Zero-cost consistency improvement.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|



Summary
speedandfunction.comtogluzdov.comindocker-compose.prod.yml*.gluzdov.comwildcard cert)EMAIL_DOMAINSintentionally kept asspeedandfunction.com— that's the corporate Google Workspace domain for authenticationChanged lines (5 total)
COOKIE_DOMAINS.temporal.speedandfunction.com.temporal.gluzdov.comWHITELIST_DOMAINS.temporal.speedandfunction.com.temporal.gluzdov.comREDIRECT_URLdefaulthttps://temporal.speedandfunction.com/...https://temporal.gluzdov.com/...CSRF_COOKIE_DOMAIN.temporal.speedandfunction.com.temporal.gluzdov.comSIGN_OUT_URLhttps://temporal.speedandfunction.com/...https://temporal.gluzdov.com/...Context
The production server already has these changes applied manually (uncommitted). This PR commits them to git to eliminate configuration drift. After merge, run
git stash && git pull && git stash dropon the EC2 server.Test plan
temporal.gluzdov.comresolves to ALB IPshttps://temporal.gluzdov.com/oauth2/callbackas authorized redirect URIspeedandfunction.comcookies are cleared on first new loginSummary by CodeRabbit