Implement chunked file reporting in Eldritch#1781
Conversation
This change implements chunked file uploads for the `report.file` Eldritch method to support large files. The `Agent::report_file` trait method now accepts an iterator of `ReportFileRequest` instead of a single request, allowing for streaming. `eldritch-libreport` now reads files in 1MB chunks. `imix` agent spawns a background thread to drive the file reading iterator and feed the transport channel. Integration tests verify that large files (100MB) are correctly chunked and transmitted. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
Implement file chunking for
report.filein Eldritch to prevent memory issues with large files.Agenttrait ineldritch-agentto support streaming viaIterator.FileChunkIteratorineldritch-libreportwith 1MB chunk size.ImixAgentto stream chunks to transport using a background thread.eldritch-libagent,eldritch-libassets,eldritch-libpivot, and tests.test_report_large_file_via_eldritchinimixto verify 100MB file upload behavior.PR created automatically by Jules for task 14733173212644407774 started by @KCarretto