Skip to content

Implement chunked file reporting in Eldritch#1781

Closed
KCarretto wants to merge 2 commits intomainfrom
eldritch-report-file-chunking-14733173212644407774
Closed

Implement chunked file reporting in Eldritch#1781
KCarretto wants to merge 2 commits intomainfrom
eldritch-report-file-chunking-14733173212644407774

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

Implement file chunking for report.file in Eldritch to prevent memory issues with large files.

  • Updated Agent trait in eldritch-agent to support streaming via Iterator.
  • Implemented FileChunkIterator in eldritch-libreport with 1MB chunk size.
  • Updated ImixAgent to stream chunks to transport using a background thread.
  • Updated mocks and fake implementations in eldritch-libagent, eldritch-libassets, eldritch-libpivot, and tests.
  • Added integration test test_report_large_file_via_eldritch in imix to verify 100MB file upload behavior.

PR created automatically by Jules for task 14733173212644407774 started by @KCarretto

This change implements chunked file uploads for the `report.file` Eldritch method to support large files.
The `Agent::report_file` trait method now accepts an iterator of `ReportFileRequest` instead of a single request, allowing for streaming.
`eldritch-libreport` now reads files in 1MB chunks.
`imix` agent spawns a background thread to drive the file reading iterator and feed the transport channel.
Integration tests verify that large files (100MB) are correctly chunked and transmitted.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 9, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2564    ±0 2564    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#929 2564 2564 0 0 0 0 29.6s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2564 0 0 5.2s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto closed this Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant