Open
Conversation
Add Doriancoin (DSV) coin classes for mainnet, testnet, and regtest. Doriancoin is a Litecoin fork with scrypt PoW and SegWit support. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove incorrect scrypt header_hash override. ElectrumX uses double_sha256 for block identification (not PoW validation), same as Litecoin. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add unit test for Doriancoin mainnet block 1000 to satisfy upstream PR requirements for altcoin additions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
After MWEB activation, Doriancoin transactions can have the MWEB flag (bit 0x8) set. DeserializerSegWit doesn't handle this flag, causing transaction parsing failures and missing UTXOs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add support for decoding bech32 (BIP173) and bech32m (BIP350) addresses, enabling ElectrumX to handle P2WPKH, P2WSH, and P2TR (Taproot) address queries. Changes: - hash.py: Add Bech32 class with encode/decode for witness programs - script.py: Add P2WPKH, P2WSH, P2TR, and generic witness_program_script helpers - coins.py: Extend pay_to_address_script to decode bech32/bech32m addresses - coins.py: Add BECH32_HRP for Bitcoin (bc/tb) and Litecoin (ltc/tltc) - tests: Add comprehensive tests for bech32m and Taproot addresses Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
|
Why do you want all this code for parsing addresses? I think it would be better to just rip the whole thing out. The server does not need to know about address/xpub/wif encodings. It is just legacy leftover code for old unused protocol versions. We should not extend it. All the base58 stuff should actually be removed, and there is no point in adding bech32 I think. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Doriancoin
Project website: https://doriancoin.org
Source: https://github.com/doriancoin-project/doriancoin