Update docker-push target to use IMG variable#524
Open
RobbertH wants to merge 1 commit intospinframework:mainfrom
Open
Update docker-push target to use IMG variable#524RobbertH wants to merge 1 commit intospinframework:mainfrom
RobbertH wants to merge 1 commit intospinframework:mainfrom
Conversation
vdice
reviewed
Jan 5, 2026
Collaborator
There was a problem hiding this comment.
Hi @RobbertH, thanks for the PR.
Alas, the docker-push-% target is currently used elsewhere to push images for e.g. runtime-class-manager or shim-downloader, etc, based on the $* arg provided. I do see the non-uniformity though, with the docker-build target conversely using ${IMG}.
To unblock you, would make docker-build docker-push REGISTRY=... TAG=... work for your needs? It isn't as streamlined as just using IMG but that should work today.
Otherwise, we'd just need to refactor things a bit more to align the targets on IMG.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
We wanted to
make docker-build docker-push IMG=...but it didn't take into account the IMG.This PR fixes that.
Issue ticket number and link
Checklist before requesting a review