feat(builder): inherit process stdin#38
Open
radu-matei wants to merge 1 commit intospinframework:mainfrom
Open
feat(builder): inherit process stdin#38radu-matei wants to merge 1 commit intospinframework:mainfrom
radu-matei wants to merge 1 commit intospinframework:mainfrom
Conversation
ref spinframework#37 This commit unconditionally inherits the `spin up` process' stdin. Given the goal of this trigger is to execute Wasm components to completion, it makes sense to inherit stdin from the parent's process and potentially block on waiting for user input. Signed-off-by: Radu Matei <radu@fermyon.com>
|
What does this do for multi-trigger apps? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #37
This commit unconditionally inherits the
spin upprocess' stdin.Given the goal of this trigger is to execute Wasm components to completion, it makes sense to inherit stdin from the parent's process and potentially block on waiting for user input.