Merged
Conversation
Update angular and splitio
[FME-7166] Add impressions properties
EmilianoSanchez
previously approved these changes
Jul 29, 2025
| "peerDependencies": { | ||
| "@angular/core": ">=16.2.12", | ||
| "rxjs": ">=6.6.0" | ||
| "@angular/core": ">=18.0.0", |
Contributor
There was a problem hiding this comment.
The README states that "This SDK is compatible with Angular 18.2.0 and above". Should we update the version here or in the readme?
Contributor
Author
There was a problem hiding this comment.
I will update it in the README doc
| }; | ||
|
|
||
| export const config: SplitIO.IBrowserSettings = { | ||
| export const config: SplitIO.IClientSideSettings = { |
Contributor
There was a problem hiding this comment.
This should be indicated as a breaking change:
- BREAKING CHANGE:
- Updated the minimum ...
- Renamed some TypeScript definitions in the `SplitIO` namespace to avoid conflicts with other Split packages: `IBrowserSettings`, `ISDK`, and `IClient` were renamed to `IClientSideSettings`, `IBrowserSDK`, and `IBrowserClient` respectively.
Contributor
There was a problem hiding this comment.
Other breaking changes from JS Browser SDK:
- Dropped support for Split Proxy below version 5.9.0. The SDK now requires Split Proxy 5.9.0 or above.
- Removed the `LocalhostFromObject` export from the default import (`import { LocalhostFromObject } from '@splitsoftware/splitio-angular'`). It is no longer necessary to manually import and configure it in the `sync.localhostMode` option to enable localhost mode.
Contributor
Author
There was a problem hiding this comment.
Adding this too
update version and changes file
Release version v4.0.0
EmilianoSanchez
previously approved these changes
Jul 30, 2025
EmilianoSanchez
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Angular SDK plugin
What did you accomplish?
How do we test the changes introduced in this PR?
Extra Notes