feat: add Provider Pattern API and modernize test suite#69
Open
luishcastroc wants to merge 1 commit intosplitio:mainfrom
Open
feat: add Provider Pattern API and modernize test suite#69luishcastroc wants to merge 1 commit intosplitio:mainfrom
luishcastroc wants to merge 1 commit intosplitio:mainfrom
Conversation
- Add provideSplitIo() function with withConfig() and withFeatureOptions() - Add SplitIoService - Convert all 22 tests from done() callbacks to async/await with firstValueFrom - Eliminate nested subscription anti-patterns in complex tests - Update CONTRIBUTORS-GUIDE.md to reflect main branch workflow All tests passing with 90% code coverage maintained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Angular SDK plugin
What did you accomplish?
Provider Pattern API (New Feature)
provideSplitIo()function withwithConfig()andwithFeatureOptions()for Angular standalone APISplitIoServicewith automatic initialization and dependency injectionsplitIoReadyGuard,splitIoReadyMatchGuard,createTreatmentGuard(),createMultiTreatmentGuard()splitIoReadyChildGuard(usesplitIoReadyGuardfor bothcanActivateandcanActivateChild)Signal Support (New Feature)
isReadySignal,isReadyFromCacheSignal,isTimedOutSignal, andhasUpdateSignalpropertiescomputed()andeffect()for reactive programming patternsTest Modernization
done()callbacks to async/await withfirstValueFromType Safety Improvements
SplitIO.Treatmentinstead of genericstringSplitIO.Attributesinstead ofanyfor attributes parameterDocumentation Updates
computed()andeffect()usagemainbranch workflow (removed outdateddevelopmentreferences)How do we test the changes introduced in this PR?
npm testAll 81 tests passing with 90.2% line coverage, 84.88% branch coverage maintained.
Key test scenarios:
provideSplitIo()getTreatment(),createClient(),track(), etc.Extra Notes
SplitServiceandSplitioGuardare still available but marked as deprecated