[FME-10568] update js commons and add fallback treatment e2e tests#897
Merged
ZamoraEmmanuel merged 18 commits intofallback-treatmentfrom Oct 29, 2025
Merged
[FME-10568] update js commons and add fallback treatment e2e tests#897ZamoraEmmanuel merged 18 commits intofallback-treatmentfrom
ZamoraEmmanuel merged 18 commits intofallback-treatmentfrom
Conversation
EmilianoSanchez
approved these changes
Oct 27, 2025
|
|
||
| assert.test('FallbackTreatment / Split factory with global fallbackTreatment defined', async t => { | ||
|
|
||
| const config = Object.assign({}, baseConfig); |
Contributor
There was a problem hiding this comment.
const splitio = SplitFactory({
...baseConfig,
fallbackTreatments: {
global: 'FALLBACK_TREATMENT'
}
});
EmilianoSanchez
requested changes
Oct 28, 2025
Contributor
EmilianoSanchez
left a comment
EmilianoSanchez
left a comment
There was a problem hiding this comment.
Emma, we need to check that TypeScript definitions are correct and include the new fallbackTreatments configuration options for the different SDK modes, by updating the ts-tests/index.ts file with the corresponding tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS SDK
What did you accomplish?
How do we test the changes introduced in this PR?
Extra Notes