Fixed #245: different padding between lines#315
Closed
alexcustos wants to merge 1 commit intosplitwise:masterfrom
Closed
Fixed #245: different padding between lines#315alexcustos wants to merge 1 commit intosplitwise:masterfrom
alexcustos wants to merge 1 commit intosplitwise:masterfrom
Conversation
mgod
force-pushed
the
master
branch
2 times, most recently
from
bdb918d to
6bc7cd4
Compare
mgod
requested changes
Sep 7, 2017
Contributor
mgod
left a comment
mgod
left a comment
There was a problem hiding this comment.
I'd love to get this bug fixed and this seems like a pretty good approach. There are a few details that should be changed.
|
|
||
| private static final String TAG = ViewSpan.class.getSimpleName(); | ||
|
|
||
| private static final char SENTINEL = ','; |
Contributor
There was a problem hiding this comment.
I'm not really comfortable adding a dependency on how the overall view is configured here. SENTINEL matches the default implementation, but breaks in some common cases like hashtags depending on configuration.
| // NOTE: only the first tag (measure) has ~2dp "padding" | ||
| // NOTE: a string with the single tag can be trimmed up to span height when the layout is inflated | ||
| String str = text.toString(); | ||
| str = str.substring(0, str.lastIndexOf(SENTINEL) + 1); |
Contributor
There was a problem hiding this comment.
I suspect rather than using a SENTINEL here, you can probably search for spans in the text and use that to figure out if there are mote.
Contributor
Author
|
Thanks for your notices, I hope I will find some time soon to revise this pull request and the #313 one. |
Contributor
|
Closed via #326 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.