Conversation
added 4 commits
February 23, 2024 10:38
Going with a single secret design as well as only supporting a single logical "replicated" connection.
Created an abstract class for most replicated database processors as there is a common pattern between these processors. Added unit tests for new replicated binding processors.
Also updated Java doc and tagged all new processors as "final"
Contributor
anthonydahanne
left a comment
anthonydahanne
left a comment
There was a problem hiding this comment.
Please add license headers to all the new source files, making sure to make it start with:
Copyright 2024 the original author or authors.
Thanks!
added 2 commits
February 29, 2024 11:20
Adding missing license text to top of new files.
|
@gm2552 do we have an example usage of how this "feels" to be consumed by the app? |
Contributor
Author
@cppforlife Yes, there is an internal document that outlines how an app would use this with and without auto configuration. I sent you a link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A replicated datasource is a single logical datasource that is comprised of two endpoints:
The data source is presented as a single binding and maps to the following spring properties:
JDBC:
R2DBC:
where
*maps toDataSourcePropertiesandR2dbcPropertiesrespectively.This PR creates a
BindingsPropertiesProcessorfor all of the currently supported databases using the following naming convention:<Database>ReplicatedBindingsPropertiesProcessor