This repository was archived by the owner on Jun 18, 2023. It is now read-only.
Open
Conversation
✅ Deploy Preview for mellow-manatee-3041fb ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Member
|
Upgrading is great, thanks.
|
Member
Author
|
Great to hear. I did cleanup the PR and from my point of view it is ready to merge. I left the tests as is and also included the (already written) channel section tests. Unit tests for the mapper can be added in another pr. My go-to default tool is jest for this. I can imagine tests to verify that the kafka, amqp, spring-stream yml are converted (without error). |
- Angular upgrade to v14 - ngx-highlightjs to v7 - rxjs to v7 - typescript to v4 Removed: - angular/compiler - tslib - ts-node - tslint (deprecated) - -> codelyzer Removed (unused): - testing (jasmine, karma) - protractor
593b6c6 to
989913d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exists to start a discussion:
The PR will need some further tweaking and more tests. However, what do you think about the direction?