This repository was archived by the owner on Aug 24, 2022. It is now read-only.
Implemented Regex.IsMatch(string, string)#1012
Open
Conversation
Member
|
I'm not sure I like this, isn't ecmascript regex mode different from the .net default? This would break app logic
|
Member
|
Hmm, that's probably close enough. I'll think about merging it. Thanks! |
Author
|
Is there something that makes you nervous that I could look into more? |
Member
|
I'm pretty sure there are some cases where .NET regex syntax would parse but produce the wrong results in javascript, which could cause very confusing failures. |
Author
|
That makes sense. I'll see if I can come up with something like that sometime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.