perf: preallocate slice with known length to optimize Mem Allocs#3768
Closed
anazcodes wants to merge 1 commit intosqlc-dev:mainfrom
Closed
perf: preallocate slice with known length to optimize Mem Allocs#3768anazcodes wants to merge 1 commit intosqlc-dev:mainfrom
anazcodes wants to merge 1 commit intosqlc-dev:mainfrom
Conversation
dosubot
bot
added
size:XS
Collaborator
|
I'm skeptical that this one change is causing much of a performance problem, so going to close this for now. |
Contributor
Author
It may not provide much observable effect in a few iterations, but it significantly improves performance with frequent iterations, and pre-allocating memory for the slice reduces the processes that occur internally when calling append in a loop. This PR was intended to write the better version of the noticed line of code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.