Update postgresql_type.go: accept "timestamp" as a case#3811
Merged
kyleconroy merged 1 commit intosqlc-dev:mainfrom Feb 10, 2025
theAnuragMishra:patch-1
Merged
Update postgresql_type.go: accept "timestamp" as a case#3811kyleconroy merged 1 commit intosqlc-dev:mainfrom theAnuragMishra:patch-1
kyleconroy merged 1 commit intosqlc-dev:mainfrom
theAnuragMishra:patch-1
Conversation
the only type accepted as a case for postgres type `timestamp` is `pg_catalog.timestamp`. It would be better if `timestamp` was also accepted directly, just as `timestamptz` is.
dosubot
bot
added
size:XS
kyleconroy
approved these changes
Feb 10, 2025
alfonsodev
pushed a commit
to ExponentiaTeam/sqlc
that referenced
this pull request
Oct 13, 2025
the only type accepted as a case for postgres type `timestamp` is `pg_catalog.timestamp`. It would be better if `timestamp` was also accepted directly, just as `timestamptz` is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the only type accepted as a case for postgres type
timestampispg_catalog.timestamp. It would be better iftimestampwas also accepted directly, just astimestamptzis.