Fix redundant rows.Close() calls in queryCode.tmpl#3856
Open
lushenle wants to merge 1 commit intosqlc-dev:mainfrom
Open
Fix redundant rows.Close() calls in queryCode.tmpl#3856lushenle wants to merge 1 commit intosqlc-dev:mainfrom
lushenle wants to merge 1 commit intosqlc-dev:mainfrom
Conversation
dosubot
bot
added
size:XS
- Updated queryCode.tmpl to use defer for rows.Close() - Ensured rows.Close() is called only once - Improved resource management following Go best practices
lushenle
force-pushed
the
fix-rows-close-issue
branch
from
68afade to
4d61b0d
Compare
dosubot
bot
added
size:L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses an issue in the generated query code template queryCode.tmpl where
rows.Close()was being called multiple times. This change ensures thatrows.Close()is only called once usingdefer, which is a best practice for resource management in Go.Changes
queryCode.tmpltemplate to usedefer rows.Close()for ensuring the rows are closed properly.rows.Close()call after the loop.Rationale
Calling
rows.Close()multiple times is unnecessary and can lead to potential issues. Usingdeferto close the rows ensures that the resource is properly released exactly once, following Go's best practices.