Skip to content

CNV-80608: PR11 - platform rule update (Drop/Restore)#14

Closed
sradco wants to merge 1 commit intoalert-mgmt-10-classificationfrom
alert-mgmt-11-platform-update
Closed

CNV-80608: PR11 - platform rule update (Drop/Restore)#14
sradco wants to merge 1 commit intoalert-mgmt-10-classificationfrom
alert-mgmt-11-platform-update

Conversation

@sradco
Copy link
Copy Markdown
Owner

@sradco sradco commented Feb 27, 2026

Alert Management API — Part 11/15: platform rule update

Summary

  • UpdatePlatformAlertRule: label changes applied via AlertRelabelConfig CRDs — computes effective labels by merging original, existing ARC overrides, and new values
  • DropPlatformAlertRule / RestorePlatformAlertRule: disable/re-enable platform alerts by adding/removing drop relabel configs in the ARC
  • GetRuleById: resolves a single relabeled rule by alert rule ID
  • ARC upsert logic: creates or updates AlertRelabelConfig resources with stamp + label-change + drop configs, deletes ARC when no changes remain
  • Platform label validation: filters protected labels, enforces allowed changes
  • AlertingRule label update path for labels that can be persisted directly on the CRD
  • Preserved drop handling: maintains existing drops for other rules when updating a shared ARC
  • Unit tests for platform update, drop/restore, label filtering, and ARC lifecycle

Dependencies

This PR is part of a stacked series. Please review in order.

  1. alert-mgmt-01: k8s foundation + health stub skeleton
    2–10. Pending — alert queries, relabel/health, management foundation, endpoints, create, delete, classification
  2. → This PR — platform rule update (Drop/Restore)
    12–15. Pending — bulk update, docs/CI/e2e, single-rule API, update user override classifications

@sradco sradco force-pushed the alert-mgmt-11-platform-update branch from f727831 to e85cd17 Compare March 1, 2026 19:05
@sradco sradco force-pushed the alert-mgmt-10-classification branch 2 times, most recently from 5ee5af7 to 7ff95cf Compare March 1, 2026 21:08
@sradco sradco force-pushed the alert-mgmt-11-platform-update branch from 083f542 to 4953fea Compare March 1, 2026 21:08
@sradco sradco force-pushed the alert-mgmt-10-classification branch from 7ff95cf to ca5937d Compare March 2, 2026 09:26
@sradco sradco force-pushed the alert-mgmt-11-platform-update branch from 4953fea to 6b25100 Compare March 2, 2026 09:26
@sradco sradco force-pushed the alert-mgmt-10-classification branch from ca5937d to e2b7208 Compare March 2, 2026 10:04
@sradco sradco force-pushed the alert-mgmt-11-platform-update branch 2 times, most recently from e020fed to beb842b Compare March 5, 2026 10:44
@sradco sradco force-pushed the alert-mgmt-10-classification branch from 05ba6c8 to 093eb63 Compare March 8, 2026 16:12
@sradco sradco force-pushed the alert-mgmt-11-platform-update branch from beb842b to 2916a5b Compare March 8, 2026 16:12
@sradco sradco changed the title alert-mgmt-11: platform rule update (Drop/Restore) CNV-80608: PR11 - platform rule update (Drop/Restore) Mar 9, 2026
@sradco sradco force-pushed the alert-mgmt-10-classification branch from 093eb63 to abf6a27 Compare March 9, 2026 14:00
@sradco sradco force-pushed the alert-mgmt-11-platform-update branch from 2916a5b to 86a805f Compare March 9, 2026 14:00
@sradco sradco force-pushed the alert-mgmt-10-classification branch from abf6a27 to a0473dc Compare March 10, 2026 13:46
@sradco sradco force-pushed the alert-mgmt-11-platform-update branch from 86a805f to 28a6295 Compare March 10, 2026 13:46
@sradco sradco force-pushed the alert-mgmt-10-classification branch from a0473dc to 5db5c73 Compare March 10, 2026 14:04
@sradco sradco force-pushed the alert-mgmt-11-platform-update branch from 28a6295 to 58a62a9 Compare March 10, 2026 14:04
@sradco sradco force-pushed the alert-mgmt-10-classification branch from 5db5c73 to 9e40002 Compare March 11, 2026 09:06
@sradco sradco force-pushed the alert-mgmt-11-platform-update branch from 58a62a9 to 8b12236 Compare March 11, 2026 09:06
… fix last-rule AlertingRule deletion

Signed-off-by: Shirly Radco <sradco@redhat.com>
Signed-off-by: João Vilaça <jvilaca@redhat.com>
Signed-off-by: Aviv Litman <alitman@redhat.com>
Co-authored-by: AI Assistant <noreply@cursor.com>
@sradco sradco force-pushed the alert-mgmt-10-classification branch from 9e40002 to c9f486a Compare March 11, 2026 09:27
@sradco sradco force-pushed the alert-mgmt-11-platform-update branch from 8b12236 to 2271a2c Compare March 11, 2026 09:27
@sradco sradco closed this Mar 12, 2026
@sradco sradco deleted the alert-mgmt-11-platform-update branch March 12, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant