alert-mgmt-03: relabel config, alerting health & AlertingRule CRD#2
Open
sradco wants to merge 1 commit intoalert-mgmt-02-k8s-alert-queriesfrom
Open
alert-mgmt-03: relabel config, alerting health & AlertingRule CRD#2sradco wants to merge 1 commit intoalert-mgmt-02-k8s-alert-queriesfrom
sradco wants to merge 1 commit intoalert-mgmt-02-k8s-alert-queriesfrom
Conversation
af91c3f to
c4c75e8
Compare
92450d6 to
8e35f9b
Compare
c4c75e8 to
a980ad1
Compare
8e35f9b to
491b730
Compare
a980ad1 to
a8171e2
Compare
491b730 to
65ec1fa
Compare
a8171e2 to
648db25
Compare
65ec1fa to
47f642b
Compare
648db25 to
8828c5a
Compare
30f53a3 to
7947697
Compare
8828c5a to
446a95a
Compare
7947697 to
8975350
Compare
446a95a to
12c4d9f
Compare
8975350 to
7b95da5
Compare
12c4d9f to
d8acbb4
Compare
7b95da5 to
36a17c2
Compare
d8acbb4 to
314d236
Compare
17a0553 to
f23cef8
Compare
…gRule CRD support Add remaining k8s layer capabilities: - AlertRelabelConfig CRUD operations for OpenShift AlertRelabelConfig CRs - RelabeledRules: applies Prometheus relabel configs to derive effective alert rules with source/management labels - AlertingHealth: route reachability checks for platform and user-workload Prometheus/Alertmanager endpoints - AlertingRule CRUD operations for OpenShift AlertingRule CRs - ExternalManagement label helpers Also adds supporting leaf packages: - pkg/managementlabels: management label constants and helpers - pkg/alert_rule: alert rule ID generation and parsing Signed-off-by: Shirly Radco <sradco@redhat.com> Signed-off-by: João Vilaça <jvilaca@redhat.com> Signed-off-by: Aviv Litman <alitman@redhat.com> Co-authored-by: AI Assistant <noreply@cursor.com>
314d236 to
d853dd3
Compare
f23cef8 to
ba845e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alert Management API — Part 3/14: relabel config, alerting health & AlertingRule CRD
Summary
AlertRelabelConfigCRD manager: informer-backed CRUD forAlertRelabelConfigresources (namespace-scoped)AlertingRuleCRD manager: informer-backed CRUD forAlertingRuleresources (cluster-monitoring namespace)relabeledRulesManager): watches PrometheusRules and ARC secrets, applies Prometheus relabel configs, and caches the resulting rule set with work-queue-based reconciliationAlertingHealthendpoint implementation: ConfigMap watcher forcluster-monitoring-config(user-workload-enabled detection), combined with route-probing health from PR 2openshift_io_rule_managed_by, ARC label/annotation keys)Clientinterface extensions:AlertingHealth(),AlertRelabelConfigs(),AlertingRules(),RelabeledRules()Dependencies
This PR is part of a stacked series. Please review in order.
4–14. Pending — management foundation, CRUD endpoints, classification, bulk update, docs/CI/e2e, single-rule API