alert-mgmt-04: management foundation#3
Open
sradco wants to merge 1 commit intoalert-mgmt-03-k8s-relabel-healthfrom
Open
alert-mgmt-04: management foundation#3sradco wants to merge 1 commit intoalert-mgmt-03-k8s-relabel-healthfrom
sradco wants to merge 1 commit intoalert-mgmt-03-k8s-relabel-healthfrom
Conversation
sradco
force-pushed
the
alert-mgmt-03-k8s-relabel-health
branch
from
92450d6 to
8e35f9b
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
ba5d29e to
ce39e4c
Compare
sradco
force-pushed
the
alert-mgmt-03-k8s-relabel-health
branch
from
8e35f9b to
491b730
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
2 times, most recently
from
ab2a9b9 to
b4e36a6
Compare
sradco
force-pushed
the
alert-mgmt-03-k8s-relabel-health
branch
from
491b730 to
65ec1fa
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
b4e36a6 to
fa0235d
Compare
sradco
force-pushed
the
alert-mgmt-03-k8s-relabel-health
branch
from
65ec1fa to
47f642b
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
fa0235d to
6b9228e
Compare
sradco
force-pushed
the
alert-mgmt-03-k8s-relabel-health
branch
from
47f642b to
30f53a3
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
6b9228e to
d505cc2
Compare
sradco
force-pushed
the
alert-mgmt-03-k8s-relabel-health
branch
from
30f53a3 to
7947697
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
d505cc2 to
a714836
Compare
sradco
force-pushed
the
alert-mgmt-03-k8s-relabel-health
branch
from
7947697 to
8975350
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
a714836 to
fff2b6b
Compare
sradco
force-pushed
the
alert-mgmt-03-k8s-relabel-health
branch
from
8975350 to
7b95da5
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
fff2b6b to
d5e9ffc
Compare
sradco
force-pushed
the
alert-mgmt-03-k8s-relabel-health
branch
from
7b95da5 to
36a17c2
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
d5e9ffc to
7f9aa14
Compare
sradco
force-pushed
the
alert-mgmt-03-k8s-relabel-health
branch
from
36a17c2 to
17a0553
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
7f9aa14 to
77ece9a
Compare
sradco
force-pushed
the
alert-mgmt-03-k8s-relabel-health
branch
from
17a0553 to
f23cef8
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
77ece9a to
8d28658
Compare
Signed-off-by: Shirly Radco <sradco@redhat.com> Signed-off-by: João Vilaça <jvilaca@redhat.com> Signed-off-by: Aviv Litman <alitman@redhat.com> Co-authored-by: AI Assistant <noreply@cursor.com>
sradco
force-pushed
the
alert-mgmt-03-k8s-relabel-health
branch
from
f23cef8 to
ba845e4
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
8d28658 to
255a057
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alert Management API — Part 4/14: management foundation
Summary
management.Clientstruct andIsPlatformAlertRulehelper to distinguish platform vs user-defined rules by namespaceNotFoundError,NotAllowedError,ValidationError,ConflictErrorfor consistent HTTP status mappingtestutils/k8s_client_mock.go) implementing all k8s interfaces for unit testsDependencies
This PR is part of a stacked series. Please review in order.
5–14. Pending — health/alerts/rules endpoints, create, delete, classification, platform update, bulk update, docs/CI/e2e, single-rule API