alert-mgmt-05: GET /health endpoint#4
Open
sradco wants to merge 1 commit intoalert-mgmt-04-mgmt-foundationfrom
Open
alert-mgmt-05: GET /health endpoint#4sradco wants to merge 1 commit intoalert-mgmt-04-mgmt-foundationfrom
sradco wants to merge 1 commit intoalert-mgmt-04-mgmt-foundationfrom
Conversation
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
ba5d29e to
ce39e4c
Compare
sradco
force-pushed
the
alert-mgmt-05-get-health
branch
from
c0d1ffd to
afaf00c
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
ce39e4c to
ab2a9b9
Compare
sradco
force-pushed
the
alert-mgmt-05-get-health
branch
from
afaf00c to
6b58b59
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
ab2a9b9 to
b4e36a6
Compare
sradco
force-pushed
the
alert-mgmt-05-get-health
branch
from
6b58b59 to
ec72a13
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
b4e36a6 to
fa0235d
Compare
sradco
force-pushed
the
alert-mgmt-05-get-health
branch
from
ec72a13 to
719410e
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
fa0235d to
6b9228e
Compare
sradco
force-pushed
the
alert-mgmt-05-get-health
branch
from
719410e to
643f009
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
6b9228e to
d505cc2
Compare
sradco
force-pushed
the
alert-mgmt-05-get-health
branch
from
643f009 to
8074317
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
d505cc2 to
a714836
Compare
sradco
force-pushed
the
alert-mgmt-05-get-health
branch
from
8074317 to
ab6d08c
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
a714836 to
fff2b6b
Compare
sradco
force-pushed
the
alert-mgmt-05-get-health
branch
from
ab6d08c to
a137d01
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
fff2b6b to
d5e9ffc
Compare
sradco
force-pushed
the
alert-mgmt-05-get-health
branch
from
a137d01 to
016c5f4
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
d5e9ffc to
7f9aa14
Compare
sradco
force-pushed
the
alert-mgmt-05-get-health
branch
from
016c5f4 to
8833735
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
7f9aa14 to
77ece9a
Compare
sradco
force-pushed
the
alert-mgmt-05-get-health
branch
2 times, most recently
from
e0aa1ff to
d92c05e
Compare
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
77ece9a to
8d28658
Compare
Add the HTTP management router layer and first endpoint: - Client interface with GetAlertingHealth method - Client factory for management client creation - GetAlertingHealth implementation: alerting health retrieval - Router skeleton with error handling, query filter helpers - GET /api/v1/alerting/health endpoint (replaces the PR01 stub) - Server wiring: management client initialization behind alert-management-api feature flag - Makefile updates: internal/ included in lint/test, e2e target added - Full test coverage with Ginkgo test suite Signed-off-by: Shirly Radco <sradco@redhat.com> Signed-off-by: João Vilaça <jvilaca@redhat.com> Signed-off-by: Aviv Litman <alitman@redhat.com> Co-authored-by: AI Assistant <noreply@cursor.com>
sradco
force-pushed
the
alert-mgmt-04-mgmt-foundation
branch
from
8d28658 to
255a057
Compare
sradco
force-pushed
the
alert-mgmt-05-get-health
branch
from
d92c05e to
d700454
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alert Management API — Part 5/14: GET /health endpoint
Summary
internal/managementrouter) with shared error handling utilitiesGET /api/v1/alerting/healthendpoint returning platform and user-workload alerting stack healthGetAlertingHealthmanagement function bridging the router to the k8s alerting health layerclient_factory.go) wiring k8s client into the management layerDependencies
This PR is part of a stacked series. Please review in order.
6–14. Pending — remaining endpoints, docs, tests