alert-mgmt-10: classification system#9
Open
sradco wants to merge 1 commit intoalert-mgmt-09-bulk-deletefrom
Open
alert-mgmt-10: classification system#9sradco wants to merge 1 commit intoalert-mgmt-09-bulk-deletefrom
sradco wants to merge 1 commit intoalert-mgmt-09-bulk-deletefrom
Conversation
92b6c8d to
fe91290
Compare
5687e5a to
905a71e
Compare
fe91290 to
6e311b5
Compare
905a71e to
3c1c593
Compare
6e311b5 to
8f12523
Compare
3c1c593 to
f6fca74
Compare
8f12523 to
907100e
Compare
f6fca74 to
f3791bc
Compare
907100e to
d3cf52e
Compare
f3791bc to
a1e95a7
Compare
d3cf52e to
b755e09
Compare
a1e95a7 to
0414d19
Compare
b755e09 to
f0d12c2
Compare
0414d19 to
4fd603f
Compare
f0d12c2 to
ab71e87
Compare
4fd603f to
d6e0660
Compare
ab71e87 to
cafef17
Compare
5100bbf to
6bff20b
Compare
cafef17 to
9c4db86
Compare
6bff20b to
4e88c65
Compare
9c4db86 to
9fe1dda
Compare
4e88c65 to
d9dbf2b
Compare
9fe1dda to
9e51c16
Compare
e87f912 to
818594d
Compare
9e51c16 to
48054c5
Compare
818594d to
60c2e5c
Compare
60c2e5c to
5ee5af7
Compare
48054c5 to
c869ec5
Compare
7ff95cf to
ca5937d
Compare
c869ec5 to
6e5bba0
Compare
…verrides Add classification labels (component, layer, component_from, layer_from) to alert rules via AlertRelabelConfig resources. Routes updates based on rule type and management status: direct to AlertingRule CR for unmanaged platform rules, ARC for operator-managed rules, and direct to PrometheusRule for unmanaged user-defined rules. GitOps-managed rules are blocked from all modifications. Signed-off-by: Shirly Radco <sradco@redhat.com> Signed-off-by: João Vilaça <jvilaca@redhat.com> Signed-off-by: Aviv Litman <alitman@redhat.com> Co-authored-by: AI Assistant <noreply@cursor.com>
6e5bba0 to
7fddfa9
Compare
ca5937d to
e2b7208
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alert Management API — Part 10/14: classification system
Summary
UpdateAlertRuleClassificationandBulkUpdateAlertRuleClassificationmanagement methodspkg/alertcomponent): label-based matching with string and regex value matchers for automatic component/layer derivationpkg/classification): layer, component, and PromQL label name validationAlertRuleClassificationPatchrouter type with explicitSetflags for distinguishing null vs absent fieldsalert_classification_configmap.go)GetAlertsto enrich alerts with classification data (component, layer, componentFrom, layerFrom)docs/alert-rule-classification.md)Dependencies
This PR is part of a stacked series. Please review in order.
2–9. Pending — alert queries, relabel/health, management foundation, endpoints, create, delete
11–14. Pending — platform update, bulk update, docs/CI/e2e, single-rule API