Skip to content

[Bugfix] Fix statcast leaderboard using the wrong season param issue#23

Merged
ss77995ss merged 3 commits intomainfrom
bugfix/statcast-leaderboard-season-params-issue
Jan 12, 2025
Merged

[Bugfix] Fix statcast leaderboard using the wrong season param issue#23
ss77995ss merged 3 commits intomainfrom
bugfix/statcast-leaderboard-season-params-issue

Conversation

@ss77995ss
Copy link
Owner

Description

  • The API is using season_start and season_end to filter season. Using season directly will cause only return the current season (current is 2024) data.

How to fix

  • Change season to season_start and season_end
params = {
-   season: season
+   season_start: season,
+   season_end: season
}

Related Issue

@ss77995ss ss77995ss added bug Something isn't working statcast Issue with Statcast features labels Jan 12, 2025
@ss77995ss ss77995ss force-pushed the bugfix/statcast-leaderboard-season-params-issue branch from 475ceab to 821e70c Compare January 12, 2025 16:23
@ss77995ss ss77995ss merged commit 5a4da47 into main Jan 12, 2025
5 checks passed
@ss77995ss ss77995ss deleted the bugfix/statcast-leaderboard-season-params-issue branch January 12, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working statcast Issue with Statcast features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant