Bump Cabal submodule: fix tarball extraction TOCTOU race#159
Merged
angerman merged 1 commit intostable-ghc-9.14from Feb 28, 2026
Merged
Bump Cabal submodule: fix tarball extraction TOCTOU race#159angerman merged 1 commit intostable-ghc-9.14from
angerman merged 1 commit intostable-ghc-9.14from
Conversation
Picks up stable-haskell/cabal@bb6a1e086 which serialises the BuildInplaceOnly tarball extraction with a lock to prevent a TOCTOU race. This fixes the intermittent "No cabal file found" errors seen on FreeBSD CI for os-string-2.0.8 when build: and host: stages of the same package are scheduled concurrently.
496f1de to
5d86c7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
When two stages of the same package (
build:andhost:in cross-compilation) are scheduled concurrently byInstallPlan.execute, both callwithTarballLocalDirectorywhich:distUnpackedSrcDirectory pkgidexists (keyed only byPackageId, not stage)Fix
The Cabal-side fix (stable-haskell/cabal#269) adds an
unpackLockto serialise thedoesDirectoryExistcheck andunpackPackageTarballcall, using the sameLock/criticalSectionpattern already used forregisterLockandcacheLock.Test plan