Add --create-missing-collections option to load_queryables#370
Open
emmanuelmathot wants to merge 3 commits intostac-utils:mainfrom
Open
Add --create-missing-collections option to load_queryables#370emmanuelmathot wants to merge 3 commits intostac-utils:mainfrom
--create-missing-collections option to load_queryables#370emmanuelmathot wants to merge 3 commits intostac-utils:mainfrom
Conversation
| queryables_data = item | ||
| break # We only need the first item | ||
|
|
||
| # Create missing collections if requested |
Member
There was a problem hiding this comment.
Suggested change
| # Create missing collections if requested | |
| # Create missing collections if requested |
Collaborator
There was a problem hiding this comment.
@emmanuelmathot I think it makes sense to have a generic SQL create_empty_collections function. Right now, you've got some slight SQL injection vulnerabilities in there (f strings and SQL are not good friends). Do you mind if I push some changes to this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new option
--create-missing-collectionsto theload_queryablescommand that automatically creates missing collections rather than failing.Changes:
create_missing_collections