Skip to content

Commit 8fcead9

Browse files
committed
fix: remove fell out of notification messages
1 parent 9c12264 commit 8fcead9

File tree

2 files changed

+2
-17
lines changed

2 files changed

+2
-17
lines changed

backend/application/core/services/observation_log.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,7 @@ def create_observation_log( # pylint: disable=too-many-arguments
5454
Assessment_Status.ASSESSMENT_STATUS_REMOVED
5555
):
5656
send_observation_notification(observation)
57-
send_observation_title_notification(
58-
observation, Observation_Log.objects.filter(observation=observation).count() == 1
59-
)
57+
send_observation_title_notification(observation)
6058

6159
return observation_log
6260

backend/application/notifications/services/send_notifications_observation_title.py

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
)
1818

1919

20-
def send_observation_title_notification(observation: Observation, observation_new: Optional[bool] = False) -> None:
20+
def send_observation_title_notification(observation: Observation) -> None:
2121
settings = Settings.load()
2222

2323
observation_title_notification_min_severity = settings.observation_title_notification_min_severity
@@ -91,19 +91,6 @@ def send_observation_title_notification(observation: Observation, observation_ne
9191
observation_title_notified.status = observation.current_status
9292
observation_title_notified.priority = observation.current_priority
9393
observation_title_notified.save()
94-
elif not observation_new:
95-
try:
96-
observation_title_notified = Observation_Title_Notified.objects.get(title=observation.title)
97-
except Observation_Title_Notified.DoesNotExist:
98-
return
99-
100-
first_line = f'Observation title "{observation.title}" fell out of notifications'
101-
102-
url = get_base_url_frontend() + '#/observations?filter={"title":"' + observation.title + '"}'
103-
104-
_send_observation_title_notifications(settings, observation, first_line, url)
105-
106-
observation_title_notified.delete()
10794

10895

10996
def _send_observation_title_notifications(

0 commit comments

Comments
 (0)