Skip to content

Conversation

@Alex-Welsh
Copy link
Member

It's time we stop using the AIO user for everything. I've made a new skc-ci-multinode user in Ark and rotated out the old vault PW. I'll update the GitHub repo secrets once this merges and backport the change to other branches

@Alex-Welsh Alex-Welsh requested a review from a team as a code owner February 6, 2026 11:03
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the credentials for the ci-multinode environment by replacing the generic skc-ci-aio user with a new, dedicated skc-ci-multinode user and its corresponding vaulted password. This is a positive security enhancement, aligning with the principle of least privilege by using environment-specific credentials. The change is straightforward and correctly implemented. I have no further comments.

Copy link
Member

@priteau priteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that I could decrypt both vaults 👍

@priteau priteau merged commit 0e4588e into stackhpc/2025.1 Feb 6, 2026
21 checks passed
@priteau priteau deleted the multinode-user branch February 6, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants