Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables internal and backend database TLS by upgrading ProxySQL to version 3.0.x and adding the necessary certificate generation tasks. A review comment identifies a hardcoded path in the root CA copy task that should be parameterized with the stackhpc_ca_secret_store variable to support different secret store backends.
etc/kayobe/ansible/secret-store/secret-store-generate-internal-tls.yml
Outdated
Show resolved
Hide resolved
seunghun1ee
force-pushed
the
enable-database-tls
branch
from
39cdc81 to
b34e018
Compare
seunghun1ee
force-pushed
the
enable-database-tls
branch
from
b34e018 to
6a816f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream Kolla-Ansible backported ProxySQL 3.0.x to 2025.1 release.
https://review.opendev.org/c/openstack/kolla-ansible/+/974712
https://review.opendev.org/c/openstack/kolla/+/974429
ProxySQL 3.0.x has a fix for the bug sysown/proxysql#4877 which prevented using TLS between database and ProxySQL.
Re-enable Database TLS and add tasks for creating certificates for ProxySQL.
Note: Two variables
database_enable_tls_internalanddatabase_enable_tls_backendhave default valuetruebut these are still explicitly set totrueto ensure existing systems can also get effect.