Skip to content

set dhcp to true in integration test #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
breuerfelix wants to merge 1 commit into
base: main
Choose a base branch
from
Open

set dhcp to true in integration test #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/controller/infrastructure/stackit/infraflow/reconcile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ func (fctx *FlowContext) ensureConfiguredNetwork(ctx context.Context) error {

networkIPv4Config := network.GetIpv4()
// In IaaS API Network can only have 1 Prefix. However, in OpenStack previously it was possible to have more.
// We never used this but let's bet sure by checking it here.
// We never used this but let's be sure by checking it here.
if len(networkIPv4Config.GetPrefixes()) > 1 {
return fmt.Errorf("multiple prefixes found for network '%s'", networkID)
}
Expand Down
1 change: 1 addition & 0 deletions test/integration/infrastructure/stackit/infrastructure_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,7 @@ func prepareIsolatedNetwork(log logr.Logger, networkName string) (*string, error
log.Info("Waiting until network is created", "networkName", networkName)

createOpts := iaas.CreateIsolatedNetworkPayload{
Dhcp: new(true),
Name: new(networkName),
Ipv4: &iaas.CreateNetworkIPv4{
CreateNetworkIPv4WithPrefix: &iaas.CreateNetworkIPv4WithPrefix{
Expand Down