Open
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kovayur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a4160d3 to
0ff0046
Compare
|
/konflux-retest acs-emailsender-on-push |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, to use ArgoCD types, we import the entire ArgoCD dependency, which brings many transitive dependencies into our project. This can lead to dependency update issues (see #2592, #2578) and may require us to use specific compatible versions of other dependencies (e.g. k8s client libs) and our Go runtime. This PR addresses this by "vendoring" the
v1alpha1.Applicationtype from ArgoCD. This is a temporary measure until these types are moved to a separate, thin module.Checklist (Definition of Done)
Test manualROX-12345: ...Test manual
TODO: Add manual testing efforts