Conversation
Molter73
reviewed
Feb 16, 2026
Contributor
Molter73
left a comment
Molter73
left a comment
There was a problem hiding this comment.
Couple small comments, overall looks good! Thanks for tackling this.
Contributor
|
BTW, I'm working on improving the output of test errors because it is horrible at the moment: #296 |
ovalenti
force-pushed
the
ovalenti/ROX-32841-quote-args
branch
from
bb74105 to
2dcfed2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introducing proper quoting of arguments when serializing the command-line.
Checklist
Automated testing