Closed
Conversation
Contributor
|
A single node development cluster (infra-pr-1769) was allocated in production infra for this PR. CI will attempt to deploy 🔌 You can connect to this cluster with: 🛠️ And pull infractl from the deployed dev infra-server with: 🚲 You can then use the dev infra instance e.g.: Further Development☕ If you make changes, you can commit and push and CI will take care of updating the development cluster. 🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with: LogsLogs for the development infra depending on your @redhat.com authuser: Or: |
Author
|
Served the purpose. The issue will be addressed in #1768 |
msugakov
added a commit
that referenced
this pull request
Mar 5, 2026
```
Running [/home/runner/golangci-lint-2.10.1-linux-amd64/golangci-lint config path] in [/home/runner/work/infra/infra] ...
Running [/home/runner/golangci-lint-2.10.1-linux-amd64/golangci-lint config verify] in [/home/runner/work/infra/infra] ...
Running [/home/runner/golangci-lint-2.10.1-linux-amd64/golangci-lint run] in [/home/runner/work/infra/infra] ...
Error: cmd/infractl/flavor/list/fancy.go:1:9: var-naming: avoid package names that conflict with Go standard library package names (revive)
package list
^
Error: pkg/buildinfo/buildinfo.go:3:9: var-naming: avoid package names that conflict with Go standard library package names (revive)
package buildinfo
^
Error: pkg/service/metrics/metrics.go:2:9: var-naming: avoid package names that conflict with Go standard library package names (revive)
package metrics
^
3 issues:
* revive: 3
Error: issues found
```
https://github.com/stackrox/infra/actions/runs/22721785912/job/65885650995?pr=1768#step:4:40
I did not break those, I did not even touch them.
Confirmed they started failing on no-op PR, see
#1769 and
https://github.com/stackrox/infra/actions/runs/22730204288/job/65916882489?pr=1769
Not sure why `master` wasn't affected.
Suppressing.
msugakov
added a commit
that referenced
this pull request
Mar 5, 2026
```
Running [/home/runner/golangci-lint-2.10.1-linux-amd64/golangci-lint config path] in [/home/runner/work/infra/infra] ...
Running [/home/runner/golangci-lint-2.10.1-linux-amd64/golangci-lint config verify] in [/home/runner/work/infra/infra] ...
Running [/home/runner/golangci-lint-2.10.1-linux-amd64/golangci-lint run] in [/home/runner/work/infra/infra] ...
Error: cmd/infractl/flavor/list/fancy.go:1:9: var-naming: avoid package names that conflict with Go standard library package names (revive)
package list
^
Error: pkg/buildinfo/buildinfo.go:3:9: var-naming: avoid package names that conflict with Go standard library package names (revive)
package buildinfo
^
Error: pkg/service/metrics/metrics.go:2:9: var-naming: avoid package names that conflict with Go standard library package names (revive)
package metrics
^
3 issues:
* revive: 3
Error: issues found
```
https://github.com/stackrox/infra/actions/runs/22721785912/job/65885650995?pr=1768#step:4:40
I did not break those, I did not even touch them.
Confirmed they started failing on no-op PR, see
#1769 and
https://github.com/stackrox/infra/actions/runs/22730204288/job/65916882489?pr=1769
Not sure why `master` wasn't affected.
Suppressing.
Used these docs
https://golangci-lint.run/docs/linters/false-positives/#exclude-issues-by-path
I tried `package blah //nolint:var-naming` but that did not work.
I did not do
```
//nolint:var-naming
package blah
```
because that would turn off the rule for the entire file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why am I getting errors like this one? https://github.com/stackrox/infra/actions/runs/22721785912/job/65885650995?pr=1768#step:4:40