fix: clear the ongoing block commit if txn fails#6976
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6976 +/- ##
===========================================
- Coverage 68.63% 60.66% -7.98%
===========================================
Files 412 412
Lines 219013 219355 +342
Branches 338 338
===========================================
- Hits 150330 133062 -17268
- Misses 68683 86293 +17610
... and 292 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
brice-stacks
left a comment
There was a problem hiding this comment.
Thanks Brady! This looks good to me. Can you just add a changelog "fragment" (see changelog.d/README.md for our new process).
Pull Request Test Coverage Report for Build 23790701954Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
If a transaction is not successfully submitted to the mempool, there's no way to differentiate between
This clears ongoing block commits when a
send_transactioncall fails so they can be resubmitted