Skip to content

fix: handle PoXAnchorBlockRequired in boot_to_epoch_25_reward_cycle#6992

Merged
francesco-stacks merged 1 commit intostacks-network:developfrom
jacinta-stacks:fix/boot-to-epoch-25-reward-cycle
Mar 26, 2026
Merged

fix: handle PoXAnchorBlockRequired in boot_to_epoch_25_reward_cycle#6992
francesco-stacks merged 1 commit intostacks-network:developfrom
jacinta-stacks:fix/boot-to-epoch-25-reward-cycle

Conversation

@jacinta-stacks
Copy link
Copy Markdown
Contributor

Fixes failing tests::signer::v0::multiple_miners_mock_sign_epoch_25. Similar problem was identified and fixed in boot_to_epoch_3. The test was panicking because get_reward_set_signers() returns a 400 PoXAnchorBlockRequired error when the prepare phase anchor block hasn't been determined yet. The original code used .expect() on this result, causing a hard failure on a transient condition. (Gives coordinator time to catch up)

Signed-off-by: Jacinta Ferrant <236437600+jacinta-stacks@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@federico-stacks federico-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Copy Markdown
Contributor

@francesco-stacks francesco-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@francesco-stacks francesco-stacks added this pull request to the merge queue Mar 26, 2026
Merged via the queue into stacks-network:develop with commit c1df1df Mar 26, 2026
1 check passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.09%. Comparing base (42fb45c) to head (d5b4923).
⚠️ Report is 143 commits behind head on develop.

❌ Your project status has failed because the head coverage (60.09%) is below the adjusted base coverage (84.96%). You can increase the head coverage or adjust the Removed Code Behavior.

❗ There is a different number of reports uploaded between BASE (42fb45c) and HEAD (d5b4923). Click for more details.

HEAD has 133 uploads less than BASE
Flag BASE (42fb45c) HEAD (d5b4923)
292 159
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6992       +/-   ##
============================================
- Coverage    84.96%   60.09%   -24.87%     
============================================
  Files          412      412               
  Lines       219958   219958               
  Branches       338      338               
============================================
- Hits        186883   132182    -54701     
- Misses       33075    87776    +54701     

see 313 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42fb45c...d5b4923. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot added the locked label Apr 3, 2026
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants