This repository was archived by the owner on Apr 2, 2025. It is now read-only.
Add pagination token + limit to OpportunityRequest model#139
Merged
theodorehreuter merged 3 commits intomainfrom Feb 5, 2025
Merged
Add pagination token + limit to OpportunityRequest model#139theodorehreuter merged 3 commits intomainfrom
theodorehreuter merged 3 commits intomainfrom
Conversation
…o token are in POST body, and changed tests and implementation to refelct this change in the model
theodorehreuter
commented
Feb 4, 2025
| "limit": limit, | ||
| } | ||
| links.append(self.pagination_link(request, body)) | ||
| search.next = pagination_token |
Contributor
Author
There was a problem hiding this comment.
Nice side effect of model change is that limit stays the same and just get carried through and all we have to update is the new pagination token for the returned body in the link object.
philvarner
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To meet the goal of having all pagination features fully contained within the POST body for
search_opportunitiestheOpportunityRequestPOST model has been updated to include alimitand 'next` field. PR changes here are accounting for and handling the downstream effects of that model change - updating the endpoint and tests.Related Issue(s):
Proposed Changes:
nextandlimitfield to theOpportunityRequestPOST body model.PR Checklist: