Generate webpage in case of exceptions#93
Open
fahad-israr wants to merge 3 commits intostarfixdev:mainfrom
Open
Generate webpage in case of exceptions#93fahad-israr wants to merge 3 commits intostarfixdev:mainfrom
fahad-israr wants to merge 3 commits intostarfixdev:mainfrom
Conversation
Collaborator
Author
|
Member
|
yeah looks like desktop not available in native yet. having custom launch implmeented probably best approach if headless exception thrown |
Collaborator
Author
|
Have added OS Specific ways to open up webpage : fahad-israr@4269882 |
maxandersen
reviewed
Aug 27, 2021
|
|
||
| package dev.starfix; | ||
| import io.quarkus.runtime.annotations.RegisterForReflection; | ||
| import jdk.jfr.StackTrace; |
maxandersen
reviewed
Aug 27, 2021
|
|
||
| public static void generateHTML(StackTraceElement[] stacktrace, String message)throws IOException, InterruptedException{ | ||
| String userHome = System.getProperty("user.home"); | ||
| File f = new File(userHome+"/starfixException.html"); |
Member
There was a problem hiding this comment.
this would cause conflicts if concurrent runs.
shuold also put it in temporary directory.
Collaborator
Author
There was a problem hiding this comment.
Have made it a temp file now and delete it on exit .
maxandersen
reviewed
Aug 27, 2021
| throw new IllegalArgumentException("Not a valid URI for git repository"); | ||
| String message = "Not a valid URI for git repository: "+cloneUrl.url; | ||
| Exception illegalArgumentException = new IllegalArgumentException(message); | ||
| generateHTML(illegalArgumentException.getStackTrace(),message); |
Member
There was a problem hiding this comment.
think better to just pass in the exception then you can also pass message and other context in.
Collaborator
Author
There was a problem hiding this comment.
yes 👍
have changed it now.
Collaborator
Author
|
@maxandersen This PR is ready for a review. |
maxandersen
reviewed
Dec 12, 2021
| try{ | ||
| cloneCmd(uri); | ||
| }catch(Exception e){ | ||
| e.printStackTrace(); |
Member
There was a problem hiding this comment.
never ok to just print out stacktrace in case of error. need to handle it or guide the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: Showing up webpage incase of issues #41