docs: fix incorrect doc comments for CasmBuilder methods#9693
Merged
orizi merged 1 commit intostarkware-libs:mainfrom Feb 18, 2026
Merged
docs: fix incorrect doc comments for CasmBuilder methods#9693orizi merged 1 commit intostarkware-libs:mainfrom
orizi merged 1 commit intostarkware-libs:mainfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
This change is |
orizi
approved these changes
Feb 18, 2026
Collaborator
orizi
left a comment
orizi
left a comment
There was a problem hiding this comment.
@orizi reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on phrwlk).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated docs to accurately reflect that
adjustedmethods always apply AP change whileunadjustedmethods never do, matching their actual behavior.Type of change
Why is this change needed?
The doc comments for 5 methods mentioned a non-existent
adjust_apparameter, implying conditional AP adjustment behavior that never existed in the code.