Skip to content

apollo_dashboard: add alert for dynamic config erroneous updates#12691

Merged
Itay-Tsabary-Starkware merged 1 commit intomain-v0.14.2from
02-18-apollo_dashboard_add_alert_for_dynamic_config_erroneous_updates
Feb 22, 2026
Merged

apollo_dashboard: add alert for dynamic config erroneous updates#12691
Itay-Tsabary-Starkware merged 1 commit intomain-v0.14.2from
02-18-apollo_dashboard_add_alert_for_dynamic_config_erroneous_updates

Conversation

@Itay-Tsabary-Starkware
Copy link
Copy Markdown
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Feb 18, 2026

Note

Low Risk
Adds a new monitoring alert and minimal wiring; main risk is alert severity/threshold mismatch causing noisy paging.

Overview
Adds a new dashboard/Grafana alert config_manager_update_error_increase that fires when config_manager_update_errors increases over a 5m window.

Wires the alert into Apollo’s Rust alert registry via a new alert_scenarios::config_manager module and includes it in get_apollo_alerts, with severity set to Regular in code (and p2 in dev_grafana_alerts.json).

Written by Cursor Bugbot for commit 6ee838b. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

Itay-Tsabary-Starkware commented Feb 18, 2026

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 02-18-apollo_config_manager_add_update_error_metric branch from bb3ee6a to 772101b Compare February 18, 2026 12:45
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 02-18-apollo_dashboard_add_alert_for_dynamic_config_erroneous_updates branch from 04bdf90 to 01bfe6d Compare February 18, 2026 12:45
Copy link
Copy Markdown
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nadin-Starkware reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Itay-Tsabary-Starkware).


crates/apollo_dashboard/src/alert_scenarios/config_manager.rs line 18 at r2 (raw file):

/// Alert when the config manager reports update errors (load/validate or set dynamic config).
/// Uses default trigger timing: condition must hold for 30s before firing, evaluated every 30s.

Do you mean PENDING_DURATION_DEFAULT? The default value may change

Code quote:

30s

@graphite-app graphite-app Bot changed the base branch from 02-18-apollo_config_manager_add_update_error_metric to graphite-base/12691 February 18, 2026 13:37
Copy link
Copy Markdown
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on nadin-Starkware).


crates/apollo_dashboard/src/alert_scenarios/config_manager.rs line 18 at r2 (raw file):

Previously, nadin-Starkware (Nadin Jbara) wrote…

Do you mean PENDING_DURATION_DEFAULT? The default value may change

Done (removed other verbose text).

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 02-18-apollo_dashboard_add_alert_for_dynamic_config_erroneous_updates branch from 01bfe6d to 723eb05 Compare February 18, 2026 13:49
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from graphite-base/12691 to 02-18-apollo_config_manager_add_update_error_metric February 18, 2026 13:49
Copy link
Copy Markdown
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nadin-Starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Itay-Tsabary-Starkware).

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from 02-18-apollo_config_manager_add_update_error_metric to main-v0.14.2 February 18, 2026 15:25
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 02-18-apollo_dashboard_add_alert_for_dynamic_config_erroneous_updates branch from 723eb05 to 1c7fadf Compare February 19, 2026 11:25
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Feb 22, 2026

Merge activity

  • Feb 22, 7:34 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Feb 22, 7:34 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 02-18-apollo_dashboard_add_alert_for_dynamic_config_erroneous_updates branch from 1c7fadf to 6ee838b Compare February 22, 2026 08:25
Copy link
Copy Markdown
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itay-Tsabary-Starkware reviewed 9 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Itay-Tsabary-Starkware).

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware added this pull request to the merge queue Feb 22, 2026
Merged via the queue into main-v0.14.2 with commit 2bf7f26 Feb 22, 2026
13 of 15 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants