apollo_dashboard: add alert for dynamic config erroneous updates#12691
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bb3ee6a to
772101b
Compare
04bdf90 to
01bfe6d
Compare
nadin-Starkware
left a comment
There was a problem hiding this comment.
@nadin-Starkware reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Itay-Tsabary-Starkware).
crates/apollo_dashboard/src/alert_scenarios/config_manager.rs line 18 at r2 (raw file):
/// Alert when the config manager reports update errors (load/validate or set dynamic config). /// Uses default trigger timing: condition must hold for 30s before firing, evaluated every 30s.
Do you mean PENDING_DURATION_DEFAULT? The default value may change
Code quote:
30s
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on nadin-Starkware).
crates/apollo_dashboard/src/alert_scenarios/config_manager.rs line 18 at r2 (raw file):
Previously, nadin-Starkware (Nadin Jbara) wrote…
Do you mean
PENDING_DURATION_DEFAULT? The default value may change
Done (removed other verbose text).
01bfe6d to
723eb05
Compare
772101b to
04a45ad
Compare
nadin-Starkware
left a comment
There was a problem hiding this comment.
@nadin-Starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Itay-Tsabary-Starkware).
723eb05 to
1c7fadf
Compare
Merge activity
|
1c7fadf to
6ee838b
Compare
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
@Itay-Tsabary-Starkware reviewed 9 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Itay-Tsabary-Starkware).

Note
Low Risk
Adds a new monitoring alert and minimal wiring; main risk is alert severity/threshold mismatch causing noisy paging.
Overview
Adds a new dashboard/Grafana alert
config_manager_update_error_increasethat fires whenconfig_manager_update_errorsincreases over a 5m window.Wires the alert into Apollo’s Rust alert registry via a new
alert_scenarios::config_managermodule and includes it inget_apollo_alerts, with severity set to Regular in code (andp2indev_grafana_alerts.json).Written by Cursor Bugbot for commit 6ee838b. This will update automatically on new commits. Configure here.