apollo_storage: add BlockHash variant to StorageReaderRequest#12700
Merged
amosStarkware merged 1 commit intomain-v0.14.1-committerfrom Feb 24, 2026
Conversation
|
This change is |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 18, 2026
amosStarkware
commented
Feb 18, 2026
Contributor
Author
amosStarkware
left a comment
amosStarkware
left a comment
There was a problem hiding this comment.
+reviewer:@nadin-Starkware
@amosStarkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on nadin-Starkware).
nadin-Starkware
approved these changes
Feb 19, 2026
Collaborator
nadin-Starkware
left a comment
nadin-Starkware
left a comment
There was a problem hiding this comment.
@nadin-Starkware reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on amosStarkware).
amosStarkware
force-pushed
the
02-17-add_storage_reader_server_to_integration_tests
branch
from
3a0df06 to
bd5bbaa
Compare
amosStarkware
force-pushed
the
02-18-apollo_storage_add_blockhash_variant_to_storagereaderrequest
branch
from
494788c to
70a9872
Compare
amosStarkware
force-pushed
the
02-17-add_storage_reader_server_to_integration_tests
branch
from
bd5bbaa to
c904cfc
Compare
amosStarkware
force-pushed
the
02-18-apollo_storage_add_blockhash_variant_to_storagereaderrequest
branch
from
70a9872 to
0d02cec
Compare
amosStarkware
force-pushed
the
02-17-add_storage_reader_server_to_integration_tests
branch
from
c904cfc to
daefce4
Compare
amosStarkware
force-pushed
the
02-18-apollo_storage_add_blockhash_variant_to_storagereaderrequest
branch
from
0d02cec to
c7b9ba2
Compare
amosStarkware
force-pushed
the
02-17-add_storage_reader_server_to_integration_tests
branch
from
daefce4 to
0e91312
Compare
amosStarkware
force-pushed
the
02-18-apollo_storage_add_blockhash_variant_to_storagereaderrequest
branch
from
c7b9ba2 to
9bdd8b8
Compare
amosStarkware
force-pushed
the
02-17-add_storage_reader_server_to_integration_tests
branch
from
0e91312 to
3f84268
Compare
amosStarkware
force-pushed
the
02-18-apollo_storage_add_blockhash_variant_to_storagereaderrequest
branch
from
9bdd8b8 to
c511828
Compare
amosStarkware
force-pushed
the
02-17-add_storage_reader_server_to_integration_tests
branch
from
3f84268 to
4ebfc3c
Compare
amosStarkware
force-pushed
the
02-18-apollo_storage_add_blockhash_variant_to_storagereaderrequest
branch
from
c511828 to
197ee5b
Compare
amosStarkware
changed the base branch from
02-17-add_storage_reader_server_to_integration_tests
to
main-v0.14.1-committer
amosStarkware
force-pushed
the
02-18-apollo_storage_add_blockhash_variant_to_storagereaderrequest
branch
from
197ee5b to
1c45b3c
Compare
Merged
via the queue into
main-v0.14.1-committer
with commit Feb 24, 2026
dd73fda
20 of 31 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Adds a new storage-reader request/response variant and a focused test; behavior is additive and limited to block-hash lookup plumbing and error mapping.
Overview
Adds a new
StorageReaderRequest::BlockHash(BlockNumber)and correspondingStorageReaderResponse::BlockHash(BlockHash)to fetch a block hash directly by block number.Wires the request through
GenericStorageReaderServerHandlerusingtxn.get_block_hash, returningNotFoundwhen absent, and extends the storage-reader types tests to persist a block hash in setup and validate the new request end-to-end.Written by Cursor Bugbot for commit 1c45b3c. This will update automatically on new commits. Configure here.