apollo_proof_manager: measure cache lock times in log#12702
apollo_proof_manager: measure cache lock times in log#12702einat-starkware merged 1 commit intomain-v0.14.2from
Conversation
|
Artifacts upload workflows: |
40b260d to
497380c
Compare
noaov1
left a comment
There was a problem hiding this comment.
@noaov1 reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on einat-starkware).
noaov1
left a comment
There was a problem hiding this comment.
@noaov1 made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on einat-starkware).
Suggestion:
- 497380c: apollo_proof_manager: measure cache lock times in log and store in proof manager before caching
497380c to
e4939fa
Compare
manager before caching
e4939fa to
52b2451
Compare
einat-starkware
left a comment
There was a problem hiding this comment.
@einat-starkware reviewed 2 files and all commit messages, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on einat-starkware).
noaov1
left a comment
There was a problem hiding this comment.
@noaov1 reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on einat-starkware).
noaov1
left a comment
There was a problem hiding this comment.
@noaov1 reviewed 1 file.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on einat-starkware).

Note
Low Risk
Mostly observability and a small ordering change in
set_proof; low functional risk but could increase log volume and affect performance in hot cache paths.Overview
Adds
tracing-based timing logs aroundProofCachemutex acquisition inget,insert, andcontains, emittinglock_duration_msfor observability.Changes
ProofManager::set_proofto write the proof to filesystem storage before inserting into the in-memory cache, avoiding cached-only state on storage failure, and adds thetracingdependency.Written by Cursor Bugbot for commit 52b2451. This will update automatically on new commits. Configure here.