Skip to content

apollo_proof_manager: measure cache lock times in log#12702

Merged
einat-starkware merged 1 commit intomain-v0.14.2from
einat/proof_manager/measure_cache_lock_time
Feb 19, 2026
Merged

apollo_proof_manager: measure cache lock times in log#12702
einat-starkware merged 1 commit intomain-v0.14.2from
einat/proof_manager/measure_cache_lock_time

Conversation

@einat-starkware
Copy link
Copy Markdown
Contributor

@einat-starkware einat-starkware commented Feb 18, 2026

Note

Low Risk
Mostly observability and a small ordering change in set_proof; low functional risk but could increase log volume and affect performance in hot cache paths.

Overview
Adds tracing-based timing logs around ProofCache mutex acquisition in get, insert, and contains, emitting lock_duration_ms for observability.

Changes ProofManager::set_proof to write the proof to filesystem storage before inserting into the in-memory cache, avoiding cached-only state on storage failure, and adds the tracing dependency.

Written by Cursor Bugbot for commit 52b2451. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@einat-starkware einat-starkware marked this pull request as ready for review February 18, 2026 12:25
@einat-starkware einat-starkware requested a review from a team as a code owner February 18, 2026 12:25
Copy link
Copy Markdown
Contributor Author

einat-starkware commented Feb 18, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 18, 2026

@einat-starkware einat-starkware force-pushed the einat/proof_manager/measure_cache_lock_time branch from 40b260d to 497380c Compare February 18, 2026 12:28
Copy link
Copy Markdown
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noaov1 reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on einat-starkware).

Copy link
Copy Markdown
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noaov1 made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on einat-starkware).


-- commits line 2 at r1:

Suggestion:

- 497380c: apollo_proof_manager: measure cache lock times in log and store in proof manager before caching 

@einat-starkware einat-starkware force-pushed the einat/proof_manager/measure_cache_lock_time branch from 497380c to e4939fa Compare February 18, 2026 16:17
@einat-starkware einat-starkware force-pushed the einat/proof_manager/measure_cache_lock_time branch from e4939fa to 52b2451 Compare February 18, 2026 23:01
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Comment thread crates/apollo_proof_manager/src/proof_manager.rs
Copy link
Copy Markdown
Contributor Author

@einat-starkware einat-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@einat-starkware reviewed 2 files and all commit messages, and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on einat-starkware).

Copy link
Copy Markdown
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noaov1 reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on einat-starkware).

Copy link
Copy Markdown
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noaov1 reviewed 1 file.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on einat-starkware).

@einat-starkware einat-starkware added this pull request to the merge queue Feb 19, 2026
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware removed this pull request from the merge queue due to a manual request Feb 19, 2026
@einat-starkware einat-starkware added this pull request to the merge queue Feb 19, 2026
Merged via the queue into main-v0.14.2 with commit 43641ab Feb 19, 2026
27 of 29 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 20, 2026
@einat-starkware einat-starkware deleted the einat/proof_manager/measure_cache_lock_time branch March 9, 2026 10:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants