apollo_central_sync: sending non-bc casms to class manager gets them from state update stream

[ShahakShama]

Note

Medium Risk
Changes the core sync event flow and when/how compiled classes are fetched and sent to the class manager, which could affect historical sync correctness and performance for pre-V0_12_0 blocks.

Overview
State sync no longer runs a separate stream_new_compiled_classes loop or processes CompiledClassAvailable events; compiled-class storage/backfill logic tied to store_sierras_and_casms_block_threshold is removed from the main sync path.

For blocks with starknet_version < STARKNET_VERSION_TO_COMPILE_FROM, the state update stream now fetches CASMs via CentralSourceTrait::get_compiled_class and passes them alongside the state diff, so store_state_diff can send non-BC classes to the class manager using add_class_and_executable_unsafe while continuing to use add_class for backward-compatible blocks.

Progress checking and RPC syncing status are simplified to use the state marker (get_state_marker) rather than the compiled-class marker, and tests are updated to reflect the new non-BC CASM fetch/send behavior.

^{Written by Cursor Bugbot for commit f36cbae. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[ShahakShama]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_central_sync: use starknet version table to determine if class is bc #12706
• apollo_central_sync: remove compiled classes stream #12705
• apollo_central_sync: sending non-bc casms to class manager gets them from state update stream #12704 👈 (View in Graphite)
• apollo_central_sync: get non bc casms in stream new state diffs #12809
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ShahakShama]

@ShahakShama resolved 1 discussion.
Reviewable status: 0 of 5 files reviewed, all discussions resolved.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

[noamsp-starkware]

@noamsp-starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ShahakShama).

---

crates/apollo_rpc/src/syncing_state.rs line 52 at r3 (raw file):

) -> StorageResult<BlockHashAndNumber> {
    let txn = storage_reader.begin_ro_txn()?;
    // TODO(shahak): This marker is no longer advanced. Use the real marker.

Does keeping this (even temporarily) break anything?

[ShahakShama]

@ShahakShama made 5 comments.
Reviewable status: 2 of 5 files reviewed, 5 unresolved discussions (waiting on noamsp-starkware).

---

crates/apollo_rpc/src/syncing_state.rs line 52 at r3 (raw file):

Previously, noamsp-starkware wrote…

Does keeping this (even temporarily) break anything?

Yes. No one uses this endpoint

---

crates/apollo_central_sync/src/lib.rs line 451 at r4 (raw file):

            for (expected_class_hash, class) in &classes {
                if let Some(casm) = non_backward_compatible_casms.get(expected_class_hash) {
                    let compiled_class_hash_v2 = casm.hash(&HashVersion::V2);

Add some log here

---

crates/apollo_central_sync/src/lib.rs line 464 at r4 (raw file):

                        )
                        .await?;
                } else {

Consider adding continue above this and removing else

---

crates/apollo_central_sync/src/sources/central_sync_test.rs line 229 at r4 (raw file):

        }))
    });
    // Block 0 is non-BC (starknet_version < V0_12_0) to exercise get_compiled_class +

I don't understand what does exercise mean in this context

---

crates/apollo_central_sync/src/sources/central_sync_test.rs line 240 at r4 (raw file):

                    StarknetVersion::V0_11_0
                } else {
                    StarknetVersion::default()

Use an explicit version. Specifically, the constant the source code uses (first version something)

[noamsp-starkware]

@noamsp-starkware made 5 comments and resolved 3 discussions.
Reviewable status: 2 of 5 files reviewed, 2 unresolved discussions (waiting on ShahakShama).

---

crates/apollo_central_sync/src/lib.rs line 451 at r4 (raw file):

Previously, ShahakShama wrote…

Add some log here

Done.

---

crates/apollo_central_sync/src/lib.rs line 464 at r4 (raw file):

Previously, ShahakShama wrote…

Consider adding continue above this and removing else

Done.

---

crates/apollo_central_sync/src/sources/central_sync_test.rs line 229 at r4 (raw file):

Previously, ShahakShama wrote…

I don't understand what does exercise mean in this context

fixed.

---

crates/apollo_central_sync/src/sources/central_sync_test.rs line 240 at r4 (raw file):

Previously, ShahakShama wrote…

Use an explicit version. Specifically, the constant the source code uses (first version something)

Done.

---

crates/apollo_rpc/src/syncing_state.rs line 52 at r3 (raw file):

Previously, ShahakShama wrote…

Yes. No one uses this endpoint

switched to state marker.

[ShahakShama]

@ShahakShama made 2 comments and resolved 1 discussion.
Reviewable status: 1 of 5 files reviewed, 2 unresolved discussions (waiting on noamsp-starkware).

---

crates/apollo_rpc/src/syncing_state.rs line 52 at r3 (raw file):

Previously, noamsp-starkware wrote…

switched to state marker.

I meant no when I wrote yes 😅
Anyway, sure
but you should use the class manager marker instead

---

crates/apollo_central_sync/src/lib.rs line 451 at r5 (raw file):

            for (expected_class_hash, class) in &classes {
                if let Some(casm) = non_backward_compatible_casms.get(expected_class_hash) {
                    trace!(

debug

[github-actions]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!