apollo_transaction_converter: make validators use task that verifies and stores the proof

[einat-starkware]

Note

Medium Risk
Changes proof verification/storage execution and error handling during consensus proposal validation; failures or task panics now surface differently and could affect proposal finalization timing.

Overview
Consensus validators now rely on apollo_transaction_converter to spawn a single VerifyAndStoreProofTask per tx that both verifies the proof and stores it in the proof manager, and validate_proposal simply awaits these tasks on ProposalFin (with timing logs) instead of doing a separate store step.

The consensus_proof_manager_store_latency histogram is moved to apollo_transaction_converter::metrics (and consumed by the orchestrator/dashboard), and a new TransactionConverterError::VerifyAndStoreProofTaskFailed is added and mapped to an internal gateway error; Grafana panel titles are updated accordingly.

^{Written by Cursor Bugbot for commit e299e8f. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[einat-starkware]

• apollo_transaction_converter: make validators use task that verifies and stores the proof #12713 👈 (View in Graphite)
• main-v0.14.2

This stack of pull requests is managed by Graphite. Learn more about stacking.

[noaov1]

@noaov1 reviewed 9 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on einat-starkware).

---

crates/apollo_consensus_orchestrator/src/validate_proposal.rs line 353 at r1 (raw file):

    task.await
        .map_err(|e| format!("Verify and store proof task panicked: {e}"))?
        .map_err(|e| format!("Verify and store proof task failed: {e}"))

We already have that string in the display of VerifyAndStoreProofTaskFailed.

Code quote:

        .map_err(|e| format!("Verify and store proof task failed: {e}"))

---

crates/apollo_transaction_converter/src/metrics.rs line 15 at r1 (raw file):

            CONSENSUS_PROOF_MANAGER_STORE_LATENCY,
            "consensus_proof_manager_store_latency",
            "Time taken to store a proof in the proof manager in seconds in the consensus orchestrator"

Suggestion:

            "Time taken to store a proof in the proof manager during consensus orchestration, in seconds"

[einat-starkware]

@einat-starkware made 1 comment and resolved 1 discussion.
Reviewable status: 7 of 9 files reviewed, 1 unresolved discussion (waiting on noaov1).

---

crates/apollo_consensus_orchestrator/src/validate_proposal.rs line 353 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

We already have that string in the display of VerifyAndStoreProofTaskFailed.

Fixed to use the underlying error

[noaov1]

@noaov1 reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on einat-starkware).