Skip to content

starknet_os_runner: add runner config (#12141)#12719

Closed
dan-starkware wants to merge 1 commit intomain-v0.14.2from
claude/update-codeowners-workspace-vmW65
Closed

starknet_os_runner: add runner config (#12141)#12719
dan-starkware wants to merge 1 commit intomain-v0.14.2from
claude/update-codeowners-workspace-vmW65

Conversation

@dan-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

Prefix the Cargo.toml pattern with `/` so it matches only the root
workspace Cargo.toml, not inner crate Cargo.toml files.

https://claude.ai/code/session_01FfPPgjuZjjUSg9jJ8QF6oM
@dan-starkware dan-starkware requested a review from a team as a code owner February 18, 2026 20:57
@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@dan-starkware dan-starkware changed the base branch from main to main-v0.14.2 February 18, 2026 20:57
@dan-starkware dan-starkware requested a review from noaov1 February 18, 2026 20:58
@chatgpt-codex-connector
Copy link
Copy Markdown

💡 Codex Review

if value.0 == Felt::ZERO {
return Err(ProofProviderError::InvalidStateDiff(format!(
"Storage deletion not allowed: try to delete storage at address {address:?}, \
key {key:?}"
)));

P1 Badge Permit zero-value storage updates in state diff validation

This check rejects any storage write where the new value is 0, but valid invoke transactions often clear slots to zero (for example, reducing a balance/allowance to empty). In the new flow, StorageProofConfig::default() enables state-change commitment generation by default, so these transactions now fail with InvalidStateDiff before proving instead of being handled normally.


if !state_diff.address_to_class_hash.is_empty() {
return Err(ProofProviderError::InvalidStateDiff(format!(
"Contract deployments not allowed: try to deploy contracts(address to class hash): \
{0:?}",
state_diff.address_to_class_hash

P1 Badge Allow class-hash updates in invoke state transitions

Rejecting any non-empty address_to_class_hash blocks valid invoke transactions that deploy contracts or replace a contract class via syscalls. Because the state-change path is the default now, these invokes are deterministically rejected as InvalidStateDiff, which makes the proving API unable to handle a real subset of supported invoke behavior.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

auto-merge was automatically disabled February 19, 2026 06:55

Pull request was closed

@dan-starkware dan-starkware deleted the claude/update-codeowners-workspace-vmW65 branch February 19, 2026 07:01
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants