Fix inline comments by converting to block comments.#6
Open
huaiyuan wants to merge 1 commit intostartup-class:masterfrom
huaiyuan:fixes
Open
Fix inline comments by converting to block comments.#6huaiyuan wants to merge 1 commit intostartup-class:masterfrom huaiyuan:fixes
huaiyuan wants to merge 1 commit intostartup-class:masterfrom
huaiyuan:fixes
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the existing implementation, a line-based inline comment (that starts with "//") preceded with js code will cause subsequent lines to be ignored (commented out) when joined to become a single line and sent to the inferior js process. This patch lessens the problem by converting inline comments to block comments.
Note that this is not foolproof, e.g., in case the js code to be sent contains a string that contains the "//" substring.