Skip to content

[6.x] Add to the replacement list #14316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edalzell wants to merge 3 commits into
base: 6.x
Choose a base branch
from
+25 −3
Open

[6.x] Add to the replacement list #14316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c5b265
Add to the replacement list
edalzell Mar 20, 2026
7dac9dc
test
edalzell Mar 20, 2026
755ccf6
✨watch this diff disappear ✨
jasonvarga Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions config/assets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,17 @@

'additional_uploadable_extensions' => [],

/*
|--------------------------------------------------------------------------
| Additional Filename Character Replacements
|--------------------------------------------------------------------------
|
| When uploading files, replace filenames that contain these characters.
|
*/

'additional_filename_replacements' => [],

/*
|--------------------------------------------------------------------------
| SVG Sanitization
Expand Down
4 changes: 2 additions & 2 deletions src/Assets/AssetUploader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ protected function getNewExtension()

public static function getSafeFilename($string)
{
$replacements = [
$replacements = array_merge([
' ' => '-',
'#' => '-',
':' => '-',
Expand All @@ -95,7 +95,7 @@ public static function getSafeFilename($string)
'%' => '-',
"'" => '-',
'--' => '-',
];
], config('statamic.assets.additional_filename_replacements', []));

return (string) Str::of(urldecode($string))
->replace(array_keys($replacements), array_values($replacements))
Expand Down
13 changes: 12 additions & 1 deletion tests/Assets/AssetUploaderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ class AssetUploaderTest extends TestCase
{
#[Test]
#[DataProvider('filenameReplacementsProvider')]
public function it_gets_safe_filename($originalFilename, $expectedFilename)
public function it_gets_safe_filename($originalFilename, $expectedFilename, $config = [])
{
config(['statamic.assets.additional_filename_replacements' => $config]);
$this->assertEquals($expectedFilename, AssetUploader::getSafeFilename($originalFilename));
}

Expand All @@ -34,6 +35,16 @@ public static function filenameReplacementsProvider()
'single quote' => ["one'two'three.jpg", 'one-two-three.jpg'],
'double dash' => ['one--two--three.jpg', 'one-two-three.jpg'],
'ascii' => ['fòô-bàř', 'foo-bar'],
'additional config' => [
'one,two%three-(6)',
'onetwo_three-6',
[
',' => '',
'(' => '',
')' => '',
'%' => '_',
],
],
];
}
}
Loading