feat: add ndarray/base/rot90#11030
Open
headlessNode wants to merge 1 commit intostdlib-js:developfrom
Open
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
headlessNode
added
Feature
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Mar 19, 2026
| * // returns <ndarray>[ [ 2, 4 ], [ 1, 3 ] ] | ||
| * | ||
| */ | ||
| function rot90( x, k, writable ) { |
Member
There was a problem hiding this comment.
Why did you choose not to support providing a list of dimensions, as done in NumPy?
Member
There was a problem hiding this comment.
It looks like you chose to follow Julia here, but I don't think that was the correct choice within the wider context of packages we should add. My recommendation:
- Rename this utility to
rotlr90to reflect that we are only rotating the last two dimensions. - Add a new package
rot90which allows specifying the two dimensions to rotate.
In principle, the former could simply be a wrapper around the latter.
kgryte
reviewed
Mar 19, 2026
| } | ||
| st = getStrides( x, true ); | ||
| offset = getOffset( x ); | ||
| nk = ( ( k % 4 ) + 4 ) % 4; |
Member
There was a problem hiding this comment.
Why are you doing two modulo operations?
Member
There was a problem hiding this comment.
What this is intended to accommodate is a negative k after the first modulo operation. Prefer an explicit conditional. Otherwise, this line is entirely opaque to future readers.
kgryte
reviewed
Mar 19, 2026
| // MAIN // | ||
|
|
||
| /** | ||
| * Rotate a matrix (or a stack of matrices) by 90 degrees. |
Member
There was a problem hiding this comment.
Suggested change
| * Rotate a matrix (or a stack of matrices) by 90 degrees. | |
| * Rotates a matrix (or a stack of matrices) by 90 degrees. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves stdlib-js/metr-issue-tracker#203.
Description
This pull request:
ndarray/base/rot90Related Issues
This pull request has the following related issues:
ndarray/base/rot90metr-issue-tracker#203Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Primarily written by Claude Code.
@stdlib-js/reviewers