Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new migration guide for upgrading consumers from @stellar/stellar-sdk v14.x to v15.0.0 (Protocol 26), consolidating both SDK-specific changes and inherited @stellar/stellar-base v15 breaking changes into a single document.
Changes:
- Introduces a v15 upgrade guide covering Soroban
AssembledTransactionvalidation changes and binding generator sanitization. - Documents inherited stellar-base breaking changes (immutable
networkPassphrase, XDR integer overflow behavior, Hermes polyfill removal). - Adds troubleshooting/verification steps for common runtime and TypeScript upgrade issues.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Size Change: 0 B Total Size: 45.4 MB ℹ️ View Unchanged
|
quietbits
approved these changes
Apr 1, 2026
Contributor
quietbits
left a comment
quietbits
left a comment
There was a problem hiding this comment.
Same feedback as in stellar/js-stellar-base#955
- Use v15.x instead of v15.0.0 to cover future minor releases - Add recommendation that all consumers upgrade - Move guide from docs/upgrade/ to docs/migration-guide/ - Add migration guide link to CHANGELOG.md v15.0.0 section - Fix Hermes polyfill FAQ: clarify silent wrong results, not a crash - Add P26 deployment dates (Testnet Apr 16, Mainnet May 6) with link - Update cross-reference link to base migration guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a migration guide for upgrading from
@stellar/stellar-sdkv14.x to v15.0.0 (Protocol 26).AssembledTransaction.fromXDR()/fromJSON()contract ID validation, binding identifier sanitization@stellar/stellar-basev15 breaking changes so SDK users don't need to cross-reference two documentsMemo.id,parseTokenAmount,Keypair.verify,cloneFrom)Follow-up commit corrects the
fromXDRcode examples to match the actual synchronous signature (Specas 3rd param, notrpcServer), fixes grep patterns for macOS portability, and aligns error strings with the actual thrown messages.Test plan
fromXDR/fromJSONexamples match the actual method signatures insrc/contract/assembled_transaction.ts