Upgrade @creit.tech/stellar-wallets-kit to v2.0.1#1958
Upgrade @creit.tech/stellar-wallets-kit to v2.0.1#1958
Conversation
|
Preview is available here: |
Co-authored-by: sagpatil <1414227+sagpatil@users.noreply.github.com>
|
Preview is available here: |
|
@copilot fix the issue with frozen lock file in the test https://github.com/stellar/laboratory/actions/runs/23264179398/job/67653173536?pr=1958 corepack enable Commit the updated lockfile: bash |
Co-authored-by: sagpatil <1414227+sagpatil@users.noreply.github.com>
Co-authored-by: sagpatil <1414227+sagpatil@users.noreply.github.com>
Co-authored-by: sagpatil <1414227+sagpatil@users.noreply.github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
... Fixed in commit |
|
Preview is available here: |
1 similar comment
|
Preview is available here: |
|
@copilot previous session had an error , please retry |
The previous session successfully fixed the lockfile — |
…-upgrade-stellar-wallet-kit Resolve merge conflicts: upgrade @creit.tech/stellar-wallets-kit to v2 on latest main
|
Preview is available here: |
There was a problem hiding this comment.
Pull request overview
Upgrades @creit.tech/stellar-wallets-kit to v2.0.1 and refactors wallet-connection/signing flows to match the library’s new static API, aiming to resolve a Next.js SSR hydration issue.
Changes:
- Upgrade
@creit.tech/stellar-wallets-kitto^2.0.1and bumpnextto15.5.15. - Refactor wallet initialization/auth/signing to use
StellarWalletsKit.init(),authModal(), and staticsignTransaction(). - Make the network limits fetch script resilient to network failures by allowing a cached output file fallback.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/hooks/useSignWithExtensionWallet.ts | Migrates signing flow from instance-based API to static authModal() + signTransaction() |
| src/helpers/getWalletKitNetwork.ts | Updates network enum mapping from WalletNetwork to Networks |
| src/components/WalletKit/WalletKitContextProvider.tsx | Reworks context to track kit initialization state and calls StellarWalletsKit.init() |
| src/components/WalletKit/ConnectWallet.tsx | Refactors connect/autoconnect flow to use authModal() and static kit methods |
| src/app/(sidebar)/smart-contracts/contract-explorer/components/InvokeContractForm.tsx | Updates signing to use static StellarWalletsKit.signTransaction() |
| scripts/fetch-network-limits.mjs | Adds cached output fallback when network fetch fails |
| package.json | Dependency upgrades for wallet kit + Next.js patch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot can you fix the failing tests |
|
@copilot apply changes based on the comments in this thread |
Fixed in commit
Also fixed a code review issue in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
Preview is available here: |
Applied in commit
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
Preview is available here: |
- WalletKitContextProvider: add explicit null guard on savedWallet before checking savedWallet.network.id to prevent TypeError crash during hydration when both savedWallet and network.id are undefined - useSignWithExtensionWallet: change isInProgress from useState to useRef so setting it does not trigger re-renders, preventing the useCallback reference from changing and breaking the infinite authModal() loop in signTx useEffect
|
Preview is available here: |
|
@jeesunikim tests are passing now . can you please review |
Upgrades Stellar Wallets Kit from v1.9.3 to v2.0.1. This release resolves the React hydration error caused by the library injecting inline styles that conflicted with Next.js SSR.
Breaking API Changes Addressed
Static class model —
StellarWalletsKitis no longer instantiated; all methods are now static:Module imports — wallet modules moved from the main package to individual sub-paths:
Other changes:
WalletNetworkenum renamed toNetworksopenModal({ onWalletSelected })callback pattern replaced byauthModal()returningPromise<{ address }>buttonTheme/modalThemereplaced by a singlethemeproperty usingSwkAppDarkTheme/SwkAppLightThemeLedgerModuleimport path:.../modules/ledger.module→.../modules/ledgerFiles Updated
WalletKitContextProvider— callsStellarWalletsKit.init()inuseEffect; context now providesisInitialized: booleaninstead of a class instanceConnectWallet— static method calls; wallet ID sourced fromStellarWalletsKit.selectedModule.productIdpost-authuseSignWithExtensionWallet—openModalcallback replaced withauthModal()promise chainInvokeContractForm—signTransactionvia static callgetWalletKitNetwork—WalletNetwork→NetworksWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
stellarwalletskit.dev/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.