Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where BytesN parsing fails when using valid all-digit hexadecimal values. The issue occurred because when serde_json::from_str successfully parsed an all-digit hex string as a JSON number, it wasn't being converted back to a string for Bytes and BytesN types, leading to incorrect parsing downstream.
Changes:
- Added
ScType::BytesandScType::BytesN(_)to the list of types that should always be treated as strings in the success branch offrom_string()method - Added a new test case
test_bytesn_32_conversion_all_digit_hexto verify the fix works for the specific failing case from issue #2245
leighmcculloch
approved these changes
Feb 12, 2026
Member
leighmcculloch
left a comment
There was a problem hiding this comment.
Looks good, one comment inline because this shadows a code path that becomes dead and wondering if there's an error relating to that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Properly parse BytesN when using valid hex values.
Why
Fix #2245.
Known limitations
N/A