modbus-rtu: don't use O_EXCL when opening the device#760
Merged
stephane merged 1 commit intostephane:masterfrom Feb 13, 2026
Merged
modbus-rtu: don't use O_EXCL when opening the device#760stephane merged 1 commit intostephane:masterfrom
stephane merged 1 commit intostephane:masterfrom
Conversation
Quote from 'man 2 open': -snip- ... In general, the behavior of O_EXCL is undefined if it is used without O_CREAT. ... -snap- Since we don't create the device file here - we just want to open (hopefully) existing ones - let's simply drop this flag to be on the safe side. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
mhei
force-pushed
the
modbus-rtu-drop-O_EXCL
branch
from
de462c7 to
d55aba8
Compare
|
@stephane, excuse me for some criticism, but please tell, why is it SO HARD to get a fix merged into the library, even small and well-formed like this one? PRs don’t get reviewed/merged for months and years. This is the first project I’m facing where it is REALLY easier to maintain own fork than get things into the upstream version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quote from 'man 2 open':
-snip-
...
In general, the behavior of O_EXCL is undefined if it is used without O_CREAT. ...
-snap-
Since we don't create the device file here - we just want to open (hopefully) existing ones - let's simply drop this flag to be on the safe side.